fix: unixfs dir redirect - Githubissues

ipfs / helia-verified-fetch

A fetch-like API for obtaining verified & trustless IPFS CIDs on the web

https://npmjs.com/package/@helia/verified-fetch

Other

14 stars 4 forks source link

fix: unixfs dir redirect #33

Closed SgtPooki closed 6 months ago

SgtPooki commented 6 months ago

fix: check redirect trailing slash if path is empty
test: add interop test for unixfs directory redirect

Title

fix: unixfs dir redirect

Description

Addresses issue found while working on https://github.com/ipfs-shipyard/helia-service-worker-gateway/issues/62 where the redirect for a directory was not being followed if the path was empty.

https://github.com/ipfs/helia-verified-fetch/pull/5 added redirect handling for unixfs directories, but did not account for the case where the path was empty.
Previous code in https://github.com/ipfs/helia-verified-fetch/pull/15 added tests for a subdirectory redirect, but did not test the case where the path was empty (which is the case when the root CID requested is a directory).

Notes & open questions

Change checklist

[ ] I have performed a self-review of my own code
[ ] I have made corresponding changes to the documentation if necessary (this includes comments as well)
[ ] I have added tests that prove my fix is effective or that my feature works

github-actions[bot] commented 6 months ago

:tada: This PR is included in version 1.3.2 :tada:

The release is available on npm package (@latest dist-tag)

Your semantic-release bot :package::rocket:

github-actions[bot] commented 6 months ago

:tada: This PR is included in version 1.10.1 :tada:

The release is available on npm package (@latest dist-tag)

Your semantic-release bot :package::rocket:

github-actions[bot] commented 4 months ago

:tada: This PR is included in version 1.0.0 :tada:

The release is available on npm package (@latest dist-tag)

Your semantic-release bot :package::rocket: