Refactor integration to use 'sensor' domain instead of custom 'yahoofinance' domain

iprak / yahoofinance

Home Assistant component which allows you to get stock updates from Yahoo finance.

MIT License

81 stars 11 forks source link

Refactor integration to use 'sensor' domain instead of custom 'yahoofinance' domain #50

Closed trankillity closed 3 years ago

trankillity commented 3 years ago

Love the integration, however it doesn't follow HA development guidelines.

The entities created should exist under the sensor domain (perfectly capable of handling everything present in this integration), rather than a new custom domain just for this integration.

Reasons for this:

Compliance with HA development guidelines
Consistency with all other integrations
UI/Frontend restrictions (most UI elements will restrict the domains usable as entities)

iprak commented 3 years ago

I think something like sensor.yahoofinance_symbol will be ideal. But will be a breaking change so not rushing this.