Open lidaobing opened 6 days ago
This pull request introduces several changes to enhance the functionality and testability of the iptux application. The primary focus is on adding support for double-clicking images, improving the debug configuration, and refactoring some existing functions for better clarity and maintainability.
Files | Changes |
---|---|
src/iptux/UiHelper.cpp src/iptux/UiHelper.h |
Refactored and organized functions, added conditional compilation for debug configuration, and introduced igtk_dialog_run function. |
src/iptux/DialogBase.cpp src/iptux/DialogBase.h |
Added chatHistoryGetImageEventBox function, refactored menu item creation, and renamed/refactored image handling functions. |
src/meson.build meson_options.txt |
Added configuration and option for CONFIG_DEBUG to support unit tests. |
src/iptux/DialogPeerTest.cpp src/iptux/ApplicationTest.cpp src/iptux/DataSettingsTest.cpp |
Included TestConfig.h and wrapped tests with CONFIG_DEBUG conditional compilation. |
Attention: Patch coverage is 64.28571%
with 10 lines
in your changes missing coverage. Please review.
Project coverage is 52.44%. Comparing base (
147c087
) to head (34f010f
).
Files | Patch % | Lines |
---|---|---|
src/iptux/UiHelper.cpp | 46.15% | 7 Missing :warning: |
src/iptux/DialogBase.cpp | 76.92% | 3 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Summary by Sourcery
This pull request introduces the ability to handle double-click events on images within the chat history, allowing users to save or copy images. It also includes enhancements to the build system to support a new
config-debug
option, and updates to the test suite to cover the new functionality and configurations.chatHistoryGetImageEventBox
inDialogBase
to retrieve image event boxes by index.igtk_dialog_run
for dialog execution, enabling better testability.config-debug
to enable CONFIG_DEBUG for unit tests.DialogPeer
andApplication
tests to include scenarios for image event box retrieval and interaction.CONFIG_DEBUG
flag.