iptux-src / iptux

A software for sharing in LAN
GNU General Public License v2.0
432 stars 128 forks source link

616 double click image #617

Open lidaobing opened 6 days ago

lidaobing commented 6 days ago

Summary by Sourcery

This pull request introduces the ability to handle double-click events on images within the chat history, allowing users to save or copy images. It also includes enhancements to the build system to support a new config-debug option, and updates to the test suite to cover the new functionality and configurations.

sourcery-ai[bot] commented 6 days ago

Reviewer's Guide by Sourcery

This pull request introduces several changes to enhance the functionality and testability of the iptux application. The primary focus is on adding support for double-clicking images, improving the debug configuration, and refactoring some existing functions for better clarity and maintainability.

File-Level Changes

Files Changes
src/iptux/UiHelper.cpp
src/iptux/UiHelper.h
Refactored and organized functions, added conditional compilation for debug configuration, and introduced igtk_dialog_run function.
src/iptux/DialogBase.cpp
src/iptux/DialogBase.h
Added chatHistoryGetImageEventBox function, refactored menu item creation, and renamed/refactored image handling functions.
src/meson.build
meson_options.txt
Added configuration and option for CONFIG_DEBUG to support unit tests.
src/iptux/DialogPeerTest.cpp
src/iptux/ApplicationTest.cpp
src/iptux/DataSettingsTest.cpp
Included TestConfig.h and wrapped tests with CONFIG_DEBUG conditional compilation.

Tips - Trigger a new Sourcery review by commenting `@sourcery-ai review` on the pull request. - Continue your discussion with Sourcery by replying directly to review comments. - You can change your review settings at any time by accessing your [dashboard](https://app.sourcery.ai): - Enable or disable the Sourcery-generated pull request summary or reviewer's guide; - Change the review language; - You can always [contact us](mailto:support@sourcery.ai) if you have any questions or feedback.
codecov[bot] commented 6 days ago

Codecov Report

Attention: Patch coverage is 64.28571% with 10 lines in your changes missing coverage. Please review.

Project coverage is 52.44%. Comparing base (147c087) to head (34f010f).

Files Patch % Lines
src/iptux/UiHelper.cpp 46.15% 7 Missing :warning:
src/iptux/DialogBase.cpp 76.92% 3 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #617 +/- ## ========================================== + Coverage 52.43% 52.44% +0.01% ========================================== Files 64 64 Lines 8533 8550 +17 ========================================== + Hits 4474 4484 +10 - Misses 4059 4066 +7 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.