search

irazasyed / laravel-gamp

📊 Laravel Google Analytics Measurement Protocol Package
https://bit.ly/laravel-gamp
MIT License
332 stars 33 forks source link

Async by default #37

Closed royduin closed 3 years ago

royduin commented 3 years ago

As non blocking is better in case Google is slow.

irazasyed commented 3 years ago

The Guzzle Async is not really true async AFAIK, So I don't think it makes sense to make enable it by default as not everyone understands its behaviour leading to more issues.

I think it's better to keep it false by default so as to advanced users that understand its usage and have a use-case for it can enable it. Thanks tho.