search

iridakos / stup

Daily notes in the terminal :penguin:
https://github.com/iridakos/stup
MIT License
415 stars 31 forks source link

Disable pager #40

Closed ghost closed 4 years ago

ghost commented 4 years ago

This resolves #25

ghost commented 4 years ago

I'm not sure if it's considered a bug that configure uses the switch (if present) instead of config file (could be changed by checking $COMMAND when applying the switch).

iridakos commented 4 years ago

I'm not sure if it's considered a bug that configure uses the switch (if present) instead of config file (could be changed by checking $COMMAND when applying the switch).

I am not sure I understand the case. Can you give me an example?

(I checked out the code and it works super fine)

ghost commented 4 years ago

I am not sure I understand the case. Can you give me an example?

  1. let's say you have pager=true in the config
  2. run stup configure --no-pager
  3. when you come to the pager wizard, it says pager is disabled

and the same for the opposite. I haven't tested this, but quick thoughts tell me it should behave this way (see line 87 of https://github.com/iridakos/stup/pull/40/commits/ba1697534599231a101cc9cd9cc07cb6879e8b89).

iridakos commented 4 years ago

Nope, it works as expected. It shows the setting saved in the configuration file.

Bringing it in :) Thank you!