search

iridl / python-maprooms

Dash maprooms and tools
0 stars 4 forks source link

Xchourio/oromia bad years #414

Closed xchourio closed 7 months ago

xchourio commented 8 months ago

Task: Update southern Oromia OND bad years Project: AA(FbF)

To achieve this, we need to produce zarr files from a shared CSV file. I've used the script from Madagascar (bad-years-v3.py) as a basis, which uses a file with similar data values (ranks). I've generalized it in such a way that we can use it for any region/country that provides us with a CSV file. The CSV (see bad_years.csv example) file should have a descriptive first line, followed by a column with the year and a column with the values (ranks) for each station (the column name should be the station). I've added validations considering that in the future, this will be handed over to the local parthners who will be executing it.

Does it make sense to ask the FbF group to take care of updating the bad_year file following this format, or is it better to do it ourselves?

zarr file is available in: /data/aaron/fbf-candidate/oromia/bad-years-v3-ond.zarr

aaron-kaplan commented 7 months ago

@xchourio one last change please: rename bad-years-v3-3season.py to southern-oromia-bad-years-v3-3season.py.

xchourio commented 7 months ago

@xchourio one last change please: rename bad-years-v3-3season.py to southern-oromia-bad-years-v3-3season.py.

Done!

xchourio commented 7 months ago

Is it ok if I merge this branch to master? (I'm already completed the rebase step)

On Mon, Apr 1, 2024 at 3:15 PM Aaron Kaplan @.***> wrote:

@.**** approved this pull request.

— Reply to this email directly, view it on GitHub https://github.com/iridl/python-maprooms/pull/414#pullrequestreview-1971946162, or unsubscribe https://github.com/notifications/unsubscribe-auth/AV37EIBPFMYSLYTISYVBB23Y3GW6LAVCNFSM6AAAAABFJN5WOCVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTSNZRHE2DMMJWGI . You are receiving this because you were mentioned.Message ID: @.***>

aaron-kaplan commented 7 months ago

Please do.