search

iroddis / asdf-mysql

A MySQL Plugin for asdf
GNU General Public License v2.0
19 stars 8 forks source link

Only works with rsync #25

Closed httpete closed 2 years ago

httpete commented 2 years ago

Hi, I have an environment which forbids rsync . Can we have a flag to use wget instead?

iroddis commented 2 years ago

Just pushed a change to move use cURL instead of rsync. Can you try it out and let me know how that works for you?

httpete commented 2 years ago

as if by magic, it worked first shot this is huge. Thank you. I think curl is more ubiquitous. 


[psuser@machine~]$ asdf list-all mysql
4.1.21
4.1.22
5.0.95
5.0.96
5.1.72
5.1.73
5.2.3
5.4.3
5.5.60
5.5.61
5.5.62
5.6.49
5.6.50
5.6.51
5.7.36
5.7.37
5.7.38
6.0.11
8.0.27
8.0.28
8.0.29
httpete commented 2 years ago

the only strangeness I am seeing now is that I Can do the install, set to global, I can see the installed mysql in the installs directory. But I keep getting command not found. I don't know if this was related to your change ( I doubt) or it's some other issue.

httpete commented 2 years ago

I can verify, that the shims/mysql is missing. It worked perfectly with asdf 0.9.0, but I tried backing off to 0.9.0 and it still doesn't make the shims for mysql.

iroddis commented 2 years ago

That's strange, I just tried a fresh install, and that didn't happen to me. Could you see if asdf reshim mysql solves the problem?

httpete commented 2 years ago

tried 10 times. Every other shim is in there perfectly. The mysql one just wont appear. This is on Centos 8 Stream if that matters?

iroddis commented 2 years ago

I'll need to get a VM set up to test out that theory. Are there any binaries in ~/.asdf/installs/mysql/X.X.X/bin for the version that's set global?

httpete commented 2 years ago

yep bin directory full of tasty mysql binaries.

httpete commented 2 years ago

what part of your code creates the shims?

iroddis commented 2 years ago

asdf core does the shimming, but the latest version of asdf-mysql put the binaries ~/.asdf/installs/mysql/{version}/mysql-directory/... , so the shimming code couldn't find anything to wrap.

Latest version fixes that issue. Could you please erase anything in ~/.asdf/installs/mysql/*, and try the installation again?

httpete commented 2 years ago

FIRST SHOT like butter. Awesome @iroddis !

iroddis commented 2 years ago

Great! Thanks for confirming and bearing with me. I'll close this out for now, but feel free to reopen it if needed.

iroddis commented 1 year ago

None of the plugin code creates the shims, it’s taken care of in the main asdf code.

On Wed, May 11, 2022, at 18:23, Pete Smith wrote:

what part of your code creates the shims?

— Reply to this email directly, view it on GitHub https://github.com/iroddis/asdf-mysql/issues/25#issuecomment-1124307604, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHMVVSNTJTYQHE6E5IPDSFTVJQQLNANCNFSM5VVFXLEQ. You are receiving this because you commented.Message ID: @.***>