irods / irods_client_globus_connector

The iRODS Globus Connector
2 stars 4 forks source link

Hardcoded timeout parameters in parallel read/write code #35

Open JustinKyleJames opened 3 years ago

JustinKyleJames commented 3 years ago

In the parallel read/write cases, there are a couple of timeout parameters.

  1. Twice waiting for a condition variable for the # of outstanding callbacks. One is waiting for the #outstanding to be 0. The other is waiting for it to be less than optimal_count. (These are set to 30 seconds.)

  2. The circular buffer used when transferring the file to the server has a timeout when pushing and popping data. (This is set to 30 seconds.)

Should these be configurable or would that be confusing? If not, what is the best setting for these.

trel commented 3 years ago

Right, we're not sure yet whether having knobs for these are more helpful than confusing.

IF we were to pull these out, and name them... are these... sufficient?

And yes, unless we determine otherwise, we'd default to 30 for these if they were not defined.