search

irods / irods_client_globus_connector

The iRODS Globus Connector
2 stars 4 forks source link

[48] Update plugin for 4.3 #49

Closed JustinKyleJames closed 1 year ago

JustinKyleJames commented 1 year ago

I changed the code to remove the irods::globus::base64_encode/decode methods and used the irods::base64_encode/decode. This will require the 4.3.1 release of iRODS before this can be released.

More detail

  1. We were picking up the wrong base64 methods so a local version was implemented for the checksum operations. This was done in 4.2.x.
  2. This wasn't sufficient for 4.3 because the clientLogin() code also calls the base64 methods. Since this connector is not calling those directly, the workaround from above would not work with 4.3.
  3. In iRODS 4.3.1, we changed the base64 methods to be in the irods namespace. This allowed clientLogin() to work. In addition, I was able to use these methods in the checksum operations so I was able to remove my local version of the base64 methods.
JustinKyleJames commented 1 year ago

Can we take another look at this and see if it is ready to merge?

JustinKyleJames commented 1 year ago

Squashed to 2 commits.

alanking commented 1 year ago

I think... you might have rebased on top of 4-2-stable? Was that on purpose? I see 4 commits.

trel commented 1 year ago

same, i see four.

trel commented 1 year ago

now i see two.