search

irods / irods_client_globus_connector

The iRODS Globus Connector
2 stars 4 forks source link

[84] On writes call rcDataObjOpen() with O_CREAT flag #86

Closed JustinKyleJames closed 5 months ago

JustinKyleJames commented 5 months ago

instead of calling rcDataObjOpen followed by rcDataObjCreate if the open fails

JustinKyleJames commented 5 months ago

That's pretty neat... Do we have any way to test this?

Just manually at the moment.

korydraughn commented 5 months ago

Ok. Since there's no support for automated tests right now, the only question left is ... have you verified the changes work as intended?

alanking commented 5 months ago

Ah, I see. No automated tests at this point.

The changes seem good to me if it works.

JustinKyleJames commented 5 months ago

Ok. Since there's no support for automated tests right now, the only question left is ... have you verified the changes work as intended?

Yes, I have done manual testing on the change.

korydraughn commented 5 months ago

Squash it.

JustinKyleJames commented 5 months ago

Squash it.

I squashed it and rebased on top of main.

JustinKyleJames commented 5 months ago

Cool cool. Pound it.

Done