irods / irods_client_nfsrods

An nfs4j Virtual File System implementation supporting the iRODS Data Grid
BSD 3-Clause "New" or "Revised" License
8 stars 9 forks source link

Added support for NFSRODS to be named when running `ips` #183

Closed ganning127 closed 10 months ago

korydraughn commented 11 months ago

Consider cross referencing the PRs like so ...

This PR depends on https://github.com/DICE-UNC/jargon/pull/423.

With that, reviewers can jump between the PRs and see the relationship.

ganning127 commented 11 months ago

Can confirm that this code works with the new Jargon code with support for naming. A few questions:

korydraughn commented 11 months ago

The .vscode/* is fine. Does it work the same if you changed it to .vscode/?

We need to think about the version bump for jargon.

ganning127 commented 11 months ago

From our discussion, seems like .vscode/ works fine, so I've made that change to .gitignore

ganning127 commented 11 months ago

Squashed!

korydraughn commented 10 months ago

I've confirmed the PR works (using the 4.3.3.0 soft-release version of Jargon).

Will add pound soon.