Atomic avu handling (main)

[FifthPotato]

Primary code mostly appears to work as expected, but can't get the test to stick. Calling it through the microservice seems to bypass policy (at least, I think) and I'm not sure if we can use the python client in tests. At a bit of a loss on how to properly test it with just icommands...

[trel]

fair. i don't think icommands have a binary that hits this API endpoint. we expose it via PRC... and yes, the microservice is already 'in the server', so wouldn't hit a PEP.

[trel]

and perhaps a run through clang-format? i see some long lines.

[korydraughn]

We're going to have to provide another mechanism for testing the atomic PEP. Creating a dependency on the PRC seems like the easiest path forward.

[trel]

agreed, for now.

[alanking]

Is this in draft because we are waiting on something? Please mark as ready for review when ready. Thanks

[trel]

please mark conversations as resolved/done when they are resolved/done. it's so close...

[FifthPotato]

I think I got it all. Did I miss anything?

[korydraughn]

Have you run all the plugin tests (i.e. the new ones and the old ones) to see if everything is passing?

If not, please do so and post a comment letting us know if they passed or failed. We'll do one more pass over the PR while that's happening.

[FifthPotato]

Yep, I've run them, and both old&new pass. This will also potentially require PRC to be added to the testing environment dockerfiles, methinks.

[alanking]

This will also potentially require PRC to be added to the testing environment dockerfiles, methinks.

Please create an issue for this and maybe link to this PR: https://github.com/irods/irods_testing_environment Thanks!

[korydraughn]

Can the test hook install the PRC? Is it weird to install python modules from a python script?

@alanking Who launches the test hook in the testing environment? root or irods?

[alanking]

Yeah, root runs the test hook in the testing environment now. A user with sudo access should run the test hook as they frequently install packages using the package manager and configure/run external services.

We install Minio packages via pip in the test hook for the S3 resource plugin. Not sure if it's weird, but there is precedent.

[korydraughn]

Good.

@FifthPotato Let's start with making the test hook install the PRC. I imagine it shouldn't take no more than one or two lines of code.

[korydraughn]

You could include issue 42 as well since it's marked as a duplicate of 38?

[korydraughn]

Please add an empty line between the main commit message and the lines that act as the body. For example:

[38,42] Primary commit message / Summary.

Body.

[FifthPotato]

Okay, messed with it until the commit msg doesn't get cut off, and put the rest into the body. Numbers added, too.

[FifthPotato]

Octothorpe'd