search

iron-fish / ironfish

A novel cryptocurrency focused on privacy and accessibility.
https://ironfish.network
Mozilla Public License 2.0
968 stars 574 forks source link

optionally retries in cli commands if user rejects Ledger request #5672

Closed hughy closed 3 days ago

hughy commented 4 days ago

Summary

if a user rejects an action on their Ledger, the command will now ~exit~ ask the user to retry instead of automatically retrying and prompting the user again to approve the action

Testing Plan

before:

image

after:

image

Documentation

Does this change require any updates to the Iron Fish Docs (ex. the RPC API Reference)? If yes, link a related documentation pull request for the website.

[ ] Yes

Breaking Change

Is this a breaking change? If yes, add notes below on why this is breaking and label it with breaking-change-rpc or breaking-change-sdk.

[ ] Yes
NullSoldier commented 4 days ago

I'm fine with this, but the reason we decided to retry is in case the user accidentally hits deny instead of accept and the pain of starting the process all over from scratch because someone accidentally rejected is a pretty painful UX experience. That being said, if you think this is a better UX I'm ok with it.

hughy commented 4 days ago

I'm fine with this, but the reason we decided to retry is in case the user accidentally hits deny instead of accept and the pain of starting the process all over from scratch because someone accidentally rejected is a pretty painful UX experience. That being said, if you think this is a better UX I'm ok with it.

I think a compromise here may be to prompt the user to retry instead of retrying automatically. That protects against accidentally rejecting a request, but avoids unexpected behavior if the user intentionally rejects the request.