search

iron-io / functions

IronFunctions - the serverless microservices platform by
https://iron.io
Apache License 2.0
3.18k stars 227 forks source link

refactor fn to seperate common and commands #657

Closed c0ze closed 7 years ago

c0ze commented 7 years ago

@kunihiko-t I refactored fn tool to make it easier to work with. Would you like to have a look ?

With this refactor, you can just 

go run main.go

and run fn tool.

kunihiko-t commented 7 years ago

Thanks! Let me check it out.

c0ze commented 7 years ago

Oops, sorry actually there are some diffs I forgot to check, just a sec.

c0ze commented 7 years ago

Sorry, I just made some changes (moved image commands into a sub folder).

This should now be ok to review. Sorry for the long diff, maybe it is better to checkout and check / test locally.

c0ze commented 7 years ago

@kunihiko-t thank you ! I am merging this then !

If possible, can you rebase jwt_proposal to new master ?

In the mean time, I will consult KG team for iron-io/functions_go#7 . (I can merge it, but I want to make sure it doesn't break anything for them.)

c0ze commented 7 years ago

@kunihiko-t iron-io/functions_go#7 is merged !

kunihiko-t commented 7 years ago

Thank you!