Fixes for python3/noetic compatibility

iron-ox / fadecandy_ros

ROS Driver for the fandecandy LED driver board

6 stars 6 forks source link

Fixes for python3/noetic compatibility #7

Closed jonbinney closed 4 years ago

jonbinney commented 4 years ago

Based on comments by @sloretz here: https://github.com/ros/rosdistro/pull/25171

Tested on melodic. May need further changes after the rosdep rule for python3-usb gets merged.

jonbinney commented 4 years ago

@reinzor could you review this? Just to make sure this doesn't break build for you on melodic (i tested quickly on my own computer on melodic, and it was fine)

jonbinney commented 4 years ago

(i sent you an invite to have "Triage" role for this repo which will let you submit reviews)

reinzor commented 4 years ago

Tested this branch on our robots, seems to work nicely on Melodic

jonbinney commented 4 years ago

Thanks @reinzor @sloretz !