[BUG] dfreds integration is no longer working.

[kwilli96]

Describe the bug I tried to just create a fix in github and push it to you but there is an issue with the merge. I think it had to do with new lines but it doesn't matter. Essentially you were getting dfreds effects using game.dfreds.effects.all and game.dfreds.effectInterface.findEffectByName but they seem to no longer exist or at least don't exist in my system.

Here are the changes that I made to get it to work:

File: Action.js

Line: 8943

const foundEffect = game.dfreds.effectInterface.findEffect({effectName:action.data.effect});

Lines: 8983-8987

list: () => {
      return game.dfreds.effectInterface.findEffects().map((effect) => {
            return i18n(effect.name);
       }).sort((a, b) => a.localeCompare(b));
},

Lines: 8917-8921

list: () => {
      return game.dfreds.effectInterface.findEffects().map((effect) => {
            return i18n(effect.name);
       }).sort((a, b) => a.localeCompare(b));
},

To Reproduce Steps to reproduce the behavior:

1. Set an active tile action to convenient effects
2. Nothing shows up.

Please complete as much of the following information as possible:

• Browser [chrome]
• Foundry Version: v12.331
• System: D&D5e v3.3.1
• Module version: v12.02
• Dfreds Convenient Effects version:
• Are there any errors in the console: Yes
  1. "all" on undefined effects: 8983-8987 and 8917-8921
  2. getEffectByName is not a defined function line: 8943

[phre3d]

Not sure if its the same issue but i just tried it with DFCE and there's no box to select the specific effect (see attached)

[kwilli96]

Not sure if its the same issue but i just tried it with DFCE and there's no box to select the specific effect (see attached)

@phre3d Yeah that is the issue that I found. If you are wanting to fix it you can make the changes to this file: %LOCALAPPDATA%\FoundryVTT\Data\modules\monks-active-tiles\actions.js

[phre3d]

Thanks, I'll try it tomorrow!