search

ironmonk88 / monks-combat-details

GNU General Public License v3.0
11 stars 7 forks source link

[BUG] Unable to Save Combat Tracker settings #49

Closed Crowguard closed 11 months ago

Crowguard commented 1 year ago

Encounter Tracker Settings won't save while Combat Details is active.

https://github.com/ironmonk88/monks-combat-details/assets/99844555/3546f3f6-e8cd-44d6-9c1d-73ced22b6882

CD 11.04-11.06 Foundry 11.307 PF2 5.3.2

mhilbrunner commented 1 year ago

This is caused by the patched save function for encounter settings not checking if game.combat is null before trying to access game.combat.setFlag().

So saving currently only works with an active encounter. If you want to modify the standard (non-module) encounter settings, you can disable the module, make any changes and then re-enable it until this is fixed.

ironmonk88 commented 11 months ago

Fixed in the latest release.