ironmonk88 / monks-combat-details

GNU General Public License v3.0
11 stars 7 forks source link

[BUG] Remember Previous setting only works for players if they end their own turn #51

Closed dineshm72 closed 11 months ago

dineshm72 commented 12 months ago

Describe the bug If the GM advances the turn during combat (rather than the player clicking End Turn), the player's stored target is not updated to be the target the player had most recently selected. When the next round comes up, the player's restored target will be the older one, not the most recent one.

To Reproduce Steps to reproduce the behavior:

  1. Set both Clear Targets after turn and Remember Previous options
  2. Select a few tokens including some players and start a combat.
  3. Have players select targets and end their own turns normally. Targets are saved as expected.
  4. Have one of the players change their target, but not click end turn. Have GM click the right arrow to advance to the next turn instead.
  5. The next time that player's turn comes around, the target that is restored will be the old one, not the most recent one.

Expected behavior Current target should be saved and restored, regardless of whether the player or the GM ends the turn.

Screenshots N/A

Please complete as much of the following information as possible:

Additional context Add any other context about the problem here.

ironmonk88 commented 11 months ago

Fixed in the latest release.