coveralls
commented
2 years ago Pull Request Test Coverage Report for Build 1646595980
- 35 of 46 (76.09%) changed or added relevant lines in 4 files are covered.
- 4 unchanged lines in 1 file lost coverage.
- Overall coverage decreased (-0.3%) to 80.564%
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
|---|---|---|---|---|---|
| src/webserver/handler_login.go | 10 | 14 | 71.43% | ||
| src/webserver/handler_login_token.go | 8 | 15 | 53.33% | ||
| <!-- | Total: | 35 | 46 | 76.09% | --> |
| Files with Coverage Reduction | New Missed Lines | % | ||
|---|---|---|---|---|
| src/webserver/handler_create_qr_token.go | 4 | 65.96% | ||
| <!-- | Total: | 4 | --> |
| Totals | |
|---|---|
| Change from base Build 1646366683: | -0.3% |
| Covered Lines: | 3113 |
| Relevant Lines: | 3864 |
ironsmile
Related to issue #27, the gbrlsnchs/jwt package needed an upgrade to a non backward-compatible version. This PR bumps it from v1 to v3 with the appropriate code changes.
Please let me know if changes are needed to better suit the project conventions.
Personal note: there is a world in which I would avoid creating an new JWT algorithm for each issue or verification, but that's probably out of the scope of this PR.