search

ironstar-io / tokaido

Zero-conf Drupal Local Development Environments with Docker
https://tokaido.io
BSD 3-Clause "New" or "Revised" License
57 stars 10 forks source link

`tok new` output still lists port 5154, but proxy service was decommissioned #239

Open ironmike-au opened 4 years ago

BrianGilbert commented 4 years ago

@otakumike What were the problems that led you to remove the proxy?

I ask because having a different port on every tok up would mean we wouldn't be able to use tokaido in our workflow.

I am willing to help find a solution that does allow for fixed port.

ironmike-au commented 4 years ago

The proxy service added a layer between the developer and their environment. In certain circumstances, when the backend was returning errors the proxy would mask them. In other cases, if the proxy encountered an issue itself then users weren't really expecting it to be there and it led to a lot of confusion, especially among junior developers.

Removing it means that startups were faster, and debugging was easier from a dev's point of view. We surveyed at the time if anybody would care and it didn't come up as an issue for anyone.

We can definitely look at adding a sort of "dedicatedPorts" option, where you could specify dedicated local ports for each of the services (nginx, haproxy, varnish, etc). But I think that's a fair bit of work in that, and it wouldn't be something we could put together for another couple of weeks

BrianGilbert commented 4 years ago

fixing the ports of the webserver within each site would also mean you couldn't run multiple tok projects at same time I think.. port clashes and all