irontec / sngrep

Ncurses SIP Messages flow viewer
GNU General Public License v3.0
1.02k stars 187 forks source link

Fixes for Stack Buffer Overflows in SIP Header Processing #480

Closed htejeda closed 7 months ago

htejeda commented 7 months ago

This pull request addresses critical vulnerabilities in sngrep's SIP header processing, specifically related to stack buffer overflows in "Call-ID", "X-Call-ID", "content-length", and "warning" headers. The fixes introduce bounds checking and ensure string null-termination, mitigating the risk of arbitrary code execution or DoS from malicious SIP messages.

Kaian commented 7 months ago

This looks awesome to me!

Thanks a lot for this contribution!