search

irundaia / sbt-sassify

sbt-web plugin for Sass files
Apache License 2.0
68 stars 17 forks source link

Cross build for SBT 1.0 #27

Closed alonsodomin closed 7 years ago

alonsodomin commented 7 years ago

Updated the base build of the plugin to use SBT 1.x while still cross-building for SBT 0.13. This required updating a few build plugins.

Some minor changes in the code have been needed due to the stronger rules in the Scala 2.12 compiler-linter.

Addresses #25

alonsodomin commented 7 years ago

@irundaia got the Travis build passing finally, any idea on how to make the appveyor one pass too?

irundaia commented 7 years ago

Hi @alonsodomin, thanks a bunch for putting in the effort. I only turned on appveyor in an attempt to automate testing on windows. Never got this working though. I'll test this on windows manually to make sure it still works. And release it for sbt 1.0 afterwards.

Do you have any idea about naming conventions for the artifacts for sbt 0.13.x v 1.0?

alonsodomin commented 7 years ago

@irundaia not aware of any specific naming convention for plugins under SBT 1.0 (if that is what you mean) and most people is just keeping the artifact names as they are. (That helps projects that are transitioning between the two SBT versions).

The SBT Bintray plugin should upload to a sbt_1.0 folder under the repo whilst the 0.13.16 version would go under sbt_0.13 one.

alonsodomin commented 7 years ago

@irundaia any success of running this on Windows?

LogicalTime commented 7 years ago

Thanks for all the work on this. Looking forward to using SBT 1.0 and this is the one plugin blocking me at the moment. Keep up the good work guys!

irundaia commented 7 years ago

@alonsodomin apologies for the delay. My day-job has been hectic this week. It works on windows as well. I'll build a new release somewhere this evening.

LogicalTime commented 7 years ago

@irundaia @alonsodomin You guys are amazing. Thanks so much.

alonsodomin commented 7 years ago

@irundaia no worries, was just following up to know if there were any more changes needed (did not have a any Windows machine around to test). Nice to see it's been merged.