isaac-sim / IsaacLab

Unified framework for robot learning built on NVIDIA Isaac Sim
https://isaac-sim.github.io/IsaacLab
Other
2.28k stars 935 forks source link

[Proposal] Add `replace_cylinders_with_capsules` option in Urdf converters #1430

Open ZiwenZhuang opened 5 days ago

ZiwenZhuang commented 5 days ago

Proposal

Adding replace_cylinders_with_capsules in the urdf converters configuration class.

Motivation

Previously in IsaacGym/legged_gym, replace_cylinders_with_capsules option can make the simulation faster and more stable. However, when radius is a lot greater than cylinders' length, the collision shape will be extremely different.

Please consider adding this option in the implementation of _get_urdf_import_config

Additional context

I've checked that this does not need any other implementations, just adding two lines of code.

  1. In _get_urdf_import_config of UrdfConverter in omni.isaac.lab/omni/Isaac/lab/sim/converters/urdf_converters.py

    截屏2024-11-18 14 24 17
  2. In UrdfConverterCfg in omni.isaac.lab/omni/Isaac/lab/sim/converters/urdf_converters_cfg.py

    截屏2024-11-18 14 23 36

Checklist

RandomOakForest commented 5 days ago

Thank you for posting this. The team will review as a possible enhancement in an upcoming release.