search

isaacharrisholt / quiffen

Quiffen is a Python package for parsing QIF (Quicken Interchange Format) files.
MIT License
33 stars 28 forks source link

fixing split percentage rounding issue #85

Closed patlachance closed 11 months ago

patlachance commented 12 months ago

Fixes #62/#63

isaacharrisholt commented 12 months ago

Looks good! I'll merge once you've got tests passing

isaacharrisholt commented 12 months ago

Please make sure to test with tox on your own machine :)

Also, it might be easier if you run poetry run pre-commit install to automatically run black etc. when you commit

patlachance commented 12 months ago

Please make sure to test with tox on your own machine :)

It's done but I'm running python 3.12 and the tox test was failing only on python 3.8. As there is no entry for tox in the makefile, I didn't think to run it. Now all tox tests pass for all of your configured python versions

Also, it might be easier if you run poetry run pre-commit install to automatically run black etc. when you commit

Thanks for the hint!

patlachance commented 11 months ago

@isaacharrisholt anything else missing before merging?

isaacharrisholt commented 11 months ago

Hey @patlachance my apologies for the delay. Assuming all the tests pass, I'll get it merged and released!

isaacharrisholt commented 11 months ago

Done!