isaacsu / twich

node.js + php realtime browser-based chat app supporting multiple rooms. Based on ry/node_chat.
http://forum.twich.me/
GNU General Public License v2.0
245 stars 22 forks source link

xss vulnerabilities in php code #12

Open isaacsu opened 13 years ago

isaacsu commented 13 years ago

$_GET variables coming through need to be escaped, but it needs to be in the context of a slightly broader design discussion. (i.e. what characters are allowed for room names, usernames, etc.)

igorw commented 13 years ago

$_SERVER should also be escaped in most cases.