search

isce-framework / s1-reader

Sentinel-1 reader
Apache License 2.0
27 stars 12 forks source link

Two layered az fm mismatch rate #101

Closed seongsujeong closed 1 year ago

seongsujeong commented 1 year ago

This PR is to separate the computation of azimuth FM rate mismatch mitigation (AZFMRMM hereinafter). Currently, the function takes in the path to the DEM, run topo internally to get lon / lat / hgt in radar grid, and make use of them for the calculation. The new structure in this PR divides the procedure into two parts; The first part is a wrapper for the second part of the function. It takes in DEM, run topo, define the rear grid, passes them into the following function, and take the return object from the following function. The second part is to take over what is calculated in the first part, and do the AZFMRMM calculation based on ETAD ATBD.

The reason for this separation is to reuse the topo outputs from the outside. Atmospheric corrections in COMPASS workflow makes use of incidence angle in radar grid, which can be obtained by running topo. Therefore, it would make more sense to run the topo once in COMPAS workflow, and pass the outputs to AZFMRMM (esp. to the second part) and the atmospheric corrections.

vbrancat commented 1 year ago

@LiangJYu can you please have a look at this? Thanks :)

LiangJYu commented 1 year ago

@LiangJYu can you please have a look at this? Thanks :)

I have reviewed already. My approval is pending the comment thread was regarding adding a DEM path check or switching to a DEM raster.

vbrancat commented 1 year ago

@seongsujeong this PR is almost done. Let's make sure we implement the required changes soon and merge it asap