search

isce-framework / s1-reader

Sentinel-1 reader
Apache License 2.0
27 stars 12 forks source link

support python 3.8 by using future.__annotations__ #111

Closed scottstanie closed 1 year ago

scottstanie commented 1 year ago

only a few typing hints had list, so this change is rather minimal

scottstanie commented 1 year ago

Any reason for holding off on merging this?

scottstanie commented 1 year ago

There wasn't any detailed conversation- it just seems like good practice to accommodate a python version that's not deprecated yet if there's no strong reason to move forward (like making heavy use of some feature that's not backward compatible). Doubly true for one like s1reader where python 3.8 incompatibility means all downstream packages can't use python 3.8 (like COMPASS, sweets, etc)