isce-framework / s1-reader

Sentinel-1 reader
Apache License 2.0
27 stars 12 forks source link

s1_burst_id: fix logic for track 174 anx crossing #115

Closed scottstanie closed 1 year ago

scottstanie commented 1 year ago

Fixes #114.

We should add a unit test for this granule that compares it to the burstId in the XML metadata (which is available since it's a 2023 acquisition):

$ grep burstId S1A_IW_SLC__1SDV_20230115T162143_20230115T162211_046796_059C50_1250.SAFE/annotation/s1a-iw1-slc-vv-20230115t162145-20230115t162210-046796-059c50-004.xml
        <burstId absolute="100514426">373734</burstId>
        <burstId absolute="100514427">373735</burstId>
        <burstId absolute="100514428">373736</burstId>
        <burstId absolute="100514429">373737</burstId>
        <burstId absolute="100514430">373738</burstId>
        <burstId absolute="100514431">373739</burstId>
        <burstId absolute="100514432">373740</burstId>
        <burstId absolute="100514433">373741</burstId>
        <burstId absolute="100514434">373742</burstId>
(mapping) staniewi:s1-reader$ grep relativeO S1A_IW_SLC__1SDV_20230115T162143_20230115T162211_046796_059C50_1250.SAFE/manifest.safe
            <safe:relativeOrbitNumber type="start">174</safe:relativeOrbitNumber>
            <safe:relativeOrbitNumber type="stop">175</safe:relativeOrbitNumber>
In [5]: s1reader.load_bursts( "./S1A_IW_SLC__1SDV_20230115T162143_20230115T162211_046796_059C50_1250.SAFE", None, 1)
measurement directory NOT found in ./S1A_IW_SLC__1SDV_20230115T162143_20230115T162211_046796_059C50_1250.SAFE, continue with metadata only.
Out[5]:
[
    Sentinel1BurstSlc(burst_id=t174_373734_iw1),
    Sentinel1BurstSlc(burst_id=t174_373735_iw1),
    Sentinel1BurstSlc(burst_id=t174_373736_iw1),
    Sentinel1BurstSlc(burst_id=t174_373737_iw1),
    Sentinel1BurstSlc(burst_id=t174_373738_iw1),
    Sentinel1BurstSlc(burst_id=t174_373739_iw1),
    Sentinel1BurstSlc(burst_id=t175_373740_iw1),
    Sentinel1BurstSlc(burst_id=t175_373741_iw1),
    Sentinel1BurstSlc(burst_id=t175_373742_iw1)
]
seongsujeong commented 1 year ago

@scottstanie Thanks for the fix. Tested it on my end with the edge case data reported by SDS team. All the RTC burst outputs in the S1 frame are where it should be based on the burst map and the burst ID

Screenshot 2023-05-09 at 14 20 01