search

isce-framework / s1-reader

Sentinel-1 reader
Apache License 2.0
27 stars 12 forks source link

Make the RFI data loading optional #119

Closed scottstanie closed 1 year ago

scottstanie commented 1 year ago

if we download only the annotation files via asfsmd, we want to be able to load bursts without needing the RFI

scottstanie commented 1 year ago

Also tagging @LiangJYu in this due to the warning fix.

I removed the warnings.simplefilter("always") in the code. This prevents me from doing

warnings.simplefilter('ignore', UserWarning)

to stop the chatty warning printing. If you think this should be something that we can't ignore, we should probably turn it into an exception, but it seems annoying to print warnings that people cant filter.

scottstanie commented 1 year ago

is this showing "merging is blocked" for other people? Not sure why it says that for me since there's 2 approvals now...

LiangJYu commented 1 year ago

More reviews don't seem to help. Maybe it's the move isce framework GitHub group that's preventing PR from merging? IIRC we were in the OPERA-ADT GitHub group before. I can't think of anything else that's different.

scottstanie commented 1 year ago

I invited Seongsu to the isce-framework org, apparently he wasn't a member 😿

seongsujeong commented 1 year ago

@scottstanie Thanks for adding me to the organization :)