Share does not represent the course of the game (WARNING: #48 spoiler)

ishefi / semantle-he

A Hebrew version of Semantle.

Other

53 stars 19 forks source link

Share does not represent the course of the game (WARNING: #48 spoiler) #33

Open yoavmiron98 opened 2 years ago

yoavmiron98 commented 2 years ago

After finishing the #48 semantle, I got the following share text: פתרתי את סמנטעל #48 ב־70 ניחושים! https://semantle-he.herokuapp.com 🟩🟩🟩🟩🟩 70 (1000/1000) 🟩🟩🟩🟩⬜ 67 (991/1000) 🟩🟩🟩🟩⬜ 50 (894/1000) 🟩🟩⬜⬜⬜ 52 (570/1000) ⬜⬜⬜⬜⬜ 49 ⬜⬜⬜⬜⬜ 40

However, the game I played looked like this: Screenshot_20220409-102948_Chrome Is this maybe a bug?

ishefi commented 2 years ago

Can you elaborate? I can't see where the difference is

yoavmiron98 commented 2 years ago

Shouldn't I see the last two rows' rank (out of 1000)?

ishefi commented 2 years ago

Ah! you are right.

So it should be:

פתרתי את סמנטעל #48 ב־70 ניחושים!
https://semantle-he.herokuapp.com/
🟩🟩🟩🟩🟩 70 (1000/1000)
🟩🟩🟩🟩⬜ 67 (991/1000)
🟩🟩🟩🟩⬜ 50 (894/1000)
🟩🟩⬜⬜⬜ 52 (570/1000)
⬜⬜⬜⬜⬜ 49 (113/1000)
⬜⬜⬜⬜⬜ 40 (101/1000)

dordadush commented 9 months ago

Ah! you are right.

So it should be:

פתרתי את סמנטעל #48 ב־70 ניחושים!
https://semantle-he.herokuapp.com/
🟩🟩🟩🟩🟩 70 (1000/1000)
🟩🟩🟩🟩⬜ 67 (991/1000)
🟩🟩🟩🟩⬜ 50 (894/1000)
🟩🟩⬜⬜⬜ 52 (570/1000)
⬜⬜⬜⬜⬜ 49 (113/1000)
⬜⬜⬜⬜⬜ 40 (101/1000)

To achieve this result, here is a PR suggestion: https://github.com/ishefi/semantle-he/pull/78