isi-nlp / DiplomacyAMR

AMR-related aspects of Diplomacy ALLAN project
BSD 3-Clause "New" or "Revised" License
0 stars 0 forks source link

:mode imperative #31

Closed saramosher888 closed 2 years ago

saramosher888 commented 2 years ago

The AMR checker is finding an error for sentences that are annotated with :mode imperative. The error is "unusual agent at :arg0". How should we resolve these? Currently they all have a country name in :arg0, but that's coming back as an error. If we don't want a country name in :arg0, I guess the alternative would be simply not to use :mode imperative. Whenever possible, I've been trying to use propose-01 instead in order to avoid this error, but the sentences below don't fit that model. Thoughts?

Examples:

uhermjakob commented 2 years ago

Thanks. I updated the AMR Checker to allow the :ARG0 to be a country under :mode imperative for all of the following: attack-01, betray-01, build-01, hold-03, lie-08, prevent-01, support-01, trust-01, tell-01. That eliminates most of the warnings (not errors) you mentioned.

For sentence dip_0001.6 in workset dip01, I personally used submit-01 instead of imperative:

(s / submit-01
      :ARG1 (a / and
            :op1 (h / hold-03
                  :ARG1 (a2 / army
                        :mod (c / country :name (n / name :op1 "England"))
                        :location (p / province :name (n2 / name :op1 "Liverpool"))))
            :op2 (m / move-01
                  :ARG1 (f / fleet
                        :mod c
                        :location (p2 / province :name (n3 / name :op1 "London")))
                  :ARG2 (s3 / sea :name (n4 / name :op1 "North" :op2 "Sea")))
            :op3 (s2 / support-01
                  :ARG0 (f2 / fleet
                        :mod c
                        :location (p3 / province :name (n5 / name :op1 "Edinburgh")))
                  :ARG1 m)))
saramosher888 commented 2 years ago

I didn't think we were using submit-01?

jkkummerfeld commented 2 years ago

What was the resolution here?

saramosher888 commented 2 years ago

I don't think we resolved the question of using submit-01 (it's not in the list of concepts that we have been using for this project so far). For the :mode imperative warnings, we still get warnings for the other concepts (propose-01, etc) but I'm ignoring them.

jkkummerfeld commented 2 years ago

Let's continue to not use submit-01 then.

Re: warnings, can you make a list of other concepts they are being raised on? Let's quickly look through the list and then for each concept either Ulf can disable the warnings, or we can plan to look at whether the annotation should change.

saramosher888 commented 2 years ago

OK, yes, I will make a list.

saramosher888 commented 2 years ago

Currently the only outstanding warnings that I can find are for fear-01 (as in "Don't worry about a fleet in Spain.") I should say that we have sometimes gotten around the :mode imperative problem by using propose-01 instead.

Example: "Ask France to support me into Munich". This sentence could be annotated two ways.

  1. :mode imperative with propose-01 (Ask France to support me). This generates a warning because propose-01 isn't allowed with :mode imperative.
  2. propose-01 with propose-01 (I propose that you propose to France that they support me to Munich). This doesn't generate a warning.

Propose-01 is bulkier to annotate than :mode imperative, but it's still easier to use because it can accommodate a wider variety of concepts without generating extra warnings. Most of the time I actually think using propose-01 is a better choice anyway, because they are usually allowing the other player room to refuse or make a different suggestion. But I would still like to see propose-01 added to the list of concepts that can be used with :mode imperative.

saramosher888 commented 2 years ago

Correction: We also have outstanding warnings for :mode imperative with demilitarize-01 and for remove-01. So here's the list:

saramosher888 commented 2 years ago

One more: hold-03. I think Ulf said that he fixed that one, but I'm still getting warnings. Example: dip_validation_0009 #46

saramosher888 commented 2 years ago

Updated list:

uhermjakob commented 2 years ago

Thanks, Sara. So far I have updated the AMR Editor to allow the following:

dip_0001.6 hold-03 :mode imperative :ARG0 army. In this annotation, shouldn't the army be :ARG1?

saramosher888 commented 2 years ago

Can we also allow :mode imperative :arg0 country for have-03, gain-02, and ally-01?

uhermjakob commented 2 years ago

OK, added.