isi-nlp / DiplomacyAMR

AMR-related aspects of Diplomacy ALLAN project
BSD 3-Clause "New" or "Revised" License
0 stars 0 forks source link

retreat-01 :ARG1 country #39

Closed uhermjakob closed 2 years ago

uhermjakob commented 2 years ago

The annotations contain a few cases with retreat-01 :ARG1 country, but in Diplomacy, technically, unit retreat, not countries. These cases should be expressed as a unit (army or fleet) from that country retreating: retreat-01 :ARG1 UNIT :mod country Example of a quick AMR Editor command to find such cases:

smosher search retreat-01 :ARG1 country

saramosher888 commented 2 years ago

OK, I see the problem and I'll fix it.

Question: Like transport-01, retreat-01 also has a slot for for the source or initial location. Do I also need to remove :arg2 for all of these and attach the location to the unit instead?

saramosher888 commented 2 years ago

I've corrected these, and I attached the location to the unit instead.