Bring `wip/docker` up to date with `master` and fix some problems

japsu commented 5 years ago

Fixed:

updated Docker instructions in README to mention config/secrets.yml
set default (insecure) SECRET_KEY_BASE and SECRET_TOKEN in docker-config.env
added --init to custom containers to make them shut down faster
fixed website port in nginx configuration

With these, the application starts and can be accessed at http://localhost:8080.

Obvious problems after this:

static content not loading (icons, ISK logo etc.)
Cannot render console from 172.19.0.1! Allowed networks: 127.0.0.1, ::1, 127.0.0.0/127.255.255.255

Open questions & further improvement:

ideally docker-based start-up would be just git clone && cd && docker-compose up without other steps required
could we include a basic env-based database.yml and secrets.yml in Git?
make a startup script that checks if rake db:create etc. has already been run and run if not

depili commented 5 years ago

The current head has moved to gitlab: https://gitlab.com/iskcrew/isk

japsu commented 5 years ago

Thanks, I'll reopen there.

On Wed, Jan 23, 2019 at 11:41 AM depili notifications@github.com wrote:

The current head has moved to gitlab: https://gitlab.com/iskcrew/isk

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/iskcrew/isk/pull/37#issuecomment-456735007, or mute the thread https://github.com/notifications/unsubscribe-auth/AAGrVS048QXxE_ifSYVoyPM9il1sRp8aks5vGC5NgaJpZM4aOOxI .

-- Santtu Pajukanta

depili commented 5 years ago

FYI: https://gitlab.com/iskcrew/isk/tree/feature/docker still needs some tidying but contains a working (on some values of working) containers and kubernetes configuration for isk

iskcrew / isk_deprecated

Bring `wip/docker` up to date with `master` and fix some problems #37