search

isotope / core

Core repository of Isotope eCommerce, an eCommerce extension for Contao Open Source CMS
https://isotopeecommerce.org
136 stars 109 forks source link

[Enhancement] Galleries per attribute #1511

Open blairwinans opened 9 years ago

blairwinans commented 9 years ago

I know that a while ago we had attached Galleries to the Attribute instead of the current behavior, which assigns it at the module level (unless I am imagining it).

This is slightly cumbersome when you want to deal with multiple gallery types per attribute. You can either tap into the generateProduct Hook or else call Gallery::createForProductAttribute() directly in the template. Not a huge deal, but I don't see why it cannot be assigned at the Attribute level instead, since the Gallery is usually in charge of actually rendering the Attribute view (for media, anyways). Makes more sense to me, but curious to hear your take on it.

aschempp commented 9 years ago

As explained on Skype (if I remember correctly): The list and reader view will use different galleries. As well as some product types that might use different galleries. Attaching them to the attribute is not possible with that, which is why it was dropped in 2.0.

However, I agree there could be improvements to that case ;-)

blairwinans commented 9 years ago

Ahh, of course—the list and reader. My mistake. Yes, and that is likely the most widely-used scenario, too.

Perhaps moving the lister/reader Gallery selection to the Attribute level with an option to override at the Module level would be the best of both worlds.. I know you'll figure something out, but in the meantime there are still plenty of options... :)