search

ispringsolutions / moodle-mod_ispring

Other
0 stars 0 forks source link

Second level namespace violate the naming rules #10

Closed purnendudash closed 7 months ago

purnendudash commented 7 months ago

Please refer to https://moodledev.io/general/development/policies/codingstyle#rules-for-level2

Your custom namespaces like fonts, help, model, pdf, report or privacy violate this naming rule. There are good reasons why it should be followed, mainly to avoid potential conflicts in the future. All these should be under classes/local/ namespace.

https://github.com/ispringsolutions/moodle-mod_ispring/blob/c4b32f7207a1b39c924c33ab29ed07671ed7a4bd/tests/testcase/user_file_creator.php#L25C23-L25C31

It should be checked access all namespaces.

Andreanapolicy commented 7 months ago

Hi, @purnendudash Fixed in #12