search

issa-tseng / janus

the two-faced application library-framework.
http://janusjs.org
37 stars 7 forks source link

Clear up options and constructorOpts naming #79

Closed issa-tseng closed 7 years ago

issa-tseng commented 7 years ago

options should always mean constructor options.

We can use eg criteria for Library options probably?

issa-tseng commented 7 years ago

Renamed the render mutator .find to .criteria; renamed constructorOpts to options.

The Library second parameter is still called options, so we now have options.options internally in that code, but it's never exposed anywhere with that name so we just have to be sneaky with how we document it to not cause confusion.