monorepo improvement: use npm/pnpm workspaces

istanbuljs / istanbuljs

monorepo containing the various nuts and bolts that facilitate istanbul.js test instrumentation

https://istanbul.js.org/

1.02k stars 236 forks source link

Open sebaplaza opened 2 years ago

sebaplaza commented 2 years ago

Instead of manual script would be great to use native monorepo utils to install npm dependencies.

We can use just npm workspaces or pnpm workspaces to manage dependencies.

This will help to have a easier way to link internal packages between them, same for bump versions.

bcoe commented 2 years ago

sounds like a good idea 👍 would happily take a patch for this.

sebaplaza commented 2 years ago

I made a PR.

But i was thinking of CI tests, force the npm>=7 version could be a problem in matrix tests

in this case, we could install npm>=7 in CI, just to manage dependencies, but the tests will continue using the desired node version to run.

sebaplaza commented 2 years ago

can i delete the "master" restriction in CI ?

Like this, we can know if branches are ok.

sebaplaza commented 1 year ago

@bcoe is ok for you ?