istio-ecosystem / authservice

Move OIDC token acquisition out of your app code and into the Istio mesh
Apache License 2.0
220 stars 62 forks source link

Check on GLIBC requirements #219

Closed dio closed 2 years ago

dio commented 2 years ago

This makes sure we can run on lte GLIBC_2.28. This adds a test using objdump -T (scripted in Go) to check the GLIBC version.

Supersedes https://github.com/istio-ecosystem/authservice/pull/218.

Signed-off-by: Dhi Aurrahman dio@rockybars.com

dio commented 2 years ago

/assign @incfly

dio commented 2 years ago

@incfly you can download the zip file on: https://github.com/istio-ecosystem/authservice/actions/runs/2094663257 (I uploaded the binary as an artifact), then you can validate it inside the ubi8 image.

$ # unzip the downloaded zip file
$ chmod +x /path/to/auth_server.stripped
$ docker run --rm -it -v /path/to/auth_server.stripped:/usr/local/bin/auth_server registry.access.redhat.com/ubi8/ubi:8.5-236.1648460182 ldd /usr/local/bin/auth_server
        linux-vdso.so.1 (0x00007ffe440c9000)
        libm.so.6 => /lib64/libm.so.6 (0x00007f3665461000)
        libpthread.so.0 => /lib64/libpthread.so.0 (0x00007f3665241000)
        libc.so.6 => /lib64/libc.so.6 (0x00007f3664e7c000)
        /lib64/ld-linux-x86-64.so.2 (0x00007f36657e3000)
istio-testing commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dio, incfly

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/istio-ecosystem/authservice/blob/master/OWNERS)~~ [incfly] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment