search

istio-ecosystem / authservice

Move OIDC token acquisition out of your app code and into the Istio mesh
Apache License 2.0
220 stars 62 forks source link

Infer the JWS signing algorithm name by looking at the provided key #247

Closed erik-h closed 7 months ago

erik-h commented 7 months ago

This handles cases where the JWS message or the key do not have a proper alg header. The alg header is optional, so some identity providers may not supply it (such as Microsoft Identity).

codecov-commenter commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

:exclamation: No coverage uploaded for pull request base (main@8e2e849). Click here to learn what that means.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #247 +/- ## ======================================= Coverage ? 90.31% ======================================= Files ? 24 Lines ? 1569 Branches ? 0 ======================================= Hits ? 1417 Misses ? 108 Partials ? 44 ``` | [Files](https://app.codecov.io/gh/istio-ecosystem/authservice/pull/247?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=istio-ecosystem) | Coverage Δ | | |---|---|---| | [internal/authz/oidc.go](https://app.codecov.io/gh/istio-ecosystem/authservice/pull/247?src=pr&el=tree&filepath=internal%2Fauthz%2Foidc.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=istio-ecosystem#diff-aW50ZXJuYWwvYXV0aHovb2lkYy5nbw==) | `93.55% <100.00%> (ø)` | |
erik-h commented 7 months ago

@nacx thanks for the review! I've added a couple comments and fixed the linter issues.

istio-testing commented 7 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: erik-h, nacx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/istio-ecosystem/authservice/blob/main/OWNERS)~~ [nacx] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
nacx commented 7 months ago

Thx!