search

istio-ecosystem / authservice

Move OIDC token acquisition out of your app code and into the Istio mesh
Apache License 2.0
220 stars 62 forks source link

Fix scan job configuration #254

Closed nacx closed 7 months ago

nacx commented 7 months ago

The upload job was not triggered int he scheduled scan, because the job was marked as failed. This changes the config to only mark as failed the scans run as part of the PR checks.

codecov-commenter commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

:exclamation: No coverage uploaded for pull request base (main@bdd1c3b). Click here to learn what that means.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #254 +/- ## ======================================= Coverage ? 90.64% ======================================= Files ? 25 Lines ? 1603 Branches ? 0 ======================================= Hits ? 1453 Misses ? 107 Partials ? 43 ```
istio-testing commented 7 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nacx, sergicastro

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/istio-ecosystem/authservice/blob/main/OWNERS)~~ [nacx] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment