search

istresearch / scrapy-cluster

This Scrapy project uses Redis and Kafka to create a distributed on demand scraping cluster.
http://scrapy-cluster.readthedocs.io/
MIT License
1.17k stars 323 forks source link

Python 3 #230

Open deed02392 opened 4 years ago

deed02392 commented 4 years ago

Issue to register the request to migrate fully to Python 3.

madisonb commented 4 years ago

@deed02392 Does the python 3 containers not work for you right now? The master branch is not up to date, but the project on the dev branch is fully python 3 compatible. I agree we should migrate all the way over but that might just mean that we drop support for python 2 setups/containers/installs.

deed02392 commented 4 years ago

Hey @madisonb, well, they were not working well with the latest Alpine Linux based Python 3 container. I basically had to update a lot of packages to get things working on the Scrapy container. I only got as far as making that run again after updating all the dependencies, but I think I will need to do the same for the other Docker components.

cyclehacker commented 4 years ago

Hi @madisonb what is the current status with running the master branch with python 3? I also noticed the requirements.txt file is depreciated, what specifically should I alter/add to ensure all requirements are met? Thanks.

madisonb commented 4 years ago

All of the unit and integration tests for the python3 docker container continue to pass, here is the build from lasst week.

https://travis-ci.org/github/istresearch/scrapy-cluster/jobs/664497952

I'm not sure there is much more to be done for the base version of this project if you are using the dev branch.

psdon commented 3 years ago

I tried to run this on Python3.8 but it doesn't work. lots of dependencies need to work on

madisonb commented 3 years ago

I will gladly accept a PR to upgrade the project to something beyond python 3.6. I have not done any testing beyond what runs in the dev branch.