ita-social-projects / ZeroWaste

Waste calculator for Zero Waste Lviv organization
MIT License
10 stars 11 forks source link

#866-fix refreshing new Category page #954

Closed NVMakarenko closed 1 week ago

NVMakarenko commented 1 week ago

dev

PROJECT

Board ticket

Code reviewers

Second Level Review

Summary of issue

The issue is similar to Board ticket

New Category is not creating because of validation failed. Error message is shown. If change locale on this stage, admin will be redirected to Category's page.

https://github.com/user-attachments/assets/89288853-787d-474e-a9ff-42ed1049ecab

Expected result 'New Categories' page is reload and displayed. 'Name' field is blank. Error message is absent.

Summary of change

  1. fix turbo_stream response.
  2. move form into partial.

https://github.com/user-attachments/assets/96c8a7fb-dd49-48d4-a69d-9f564e2e190a

CHECK LIST

codecov[bot] commented 1 week ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 91.76%. Comparing base (51ec11c) to head (af5663f). Report is 4 commits behind head on develop.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #954 +/- ## ======================================== Coverage 91.76% 91.76% ======================================== Files 73 73 Lines 1044 1044 ======================================== Hits 958 958 Misses 86 86 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


🚨 Try these New Features: