search

ita-social-projects / ZeroWaste

Waste calculator for Zero Waste Lviv organization
MIT License
10 stars 11 forks source link

Added accessibility features on publick pages #968

Closed DanielVajnagi closed 4 days ago

DanielVajnagi commented 1 week ago

Code reviewers

Second Level Review

Summary of issue

To add aria-label, alt, title on public pages

Summary of change

Added to burger menu button, other pages is OK

CHECK LIST

codecov[bot] commented 1 week ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 90.48%. Comparing base (9fa42f9) to head (e35f8fa). Report is 29 commits behind head on develop.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #968 +/- ## =========================================== - Coverage 91.16% 90.48% -0.68% =========================================== Files 70 73 +3 Lines 973 1062 +89 =========================================== + Hits 887 961 +74 - Misses 86 101 +15 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

🚨 Try these New Features:

github-actions[bot] commented 4 days ago

:cold_sweat: RSpec failure

372 examples, 52 failures, 15 pending | Example | Description | Message | | ---------------------------------------------------- | ------------------------------------------------------------------------------------------------------------------------------------------------------- | ---------------------------------- | | ./spec/features/account/calculators_spec.rb:11 | visit admin page visits admin page | "Українська" is not a valid locale | | ./spec/features/account/categories_spec.rb:11 | visit admin page visits admin page | "Українська" is not a valid locale | | ./spec/features/account/create_calculator_spec.rb:16 | Create Calculator Page when user clicks button Create calculator shows message that calculator has been successfully created | "Українська" is not a valid locale | | ./spec/features/account/create_calculator_spec.rb:25 | Create Calculator Page when user clicks button Create calculator redirects to Index calculator page | "Українська" is not a valid locale | | ./spec/features/account/create_calculator_spec.rb:33 | Create Calculator Page when user fill in the Name field with name that already exist shows message that name is already has been taken | "Українська" is not a valid locale | | ./spec/features/account/create_calculator_spec.rb:42 | Create Calculator Page when user fill in the Name field with name shorter than 2 symbols shows message that name is too short | "Українська" is not a valid locale | | ./spec/features/account/create_calculator_spec.rb:51 | Create Calculator Page when user fill in the Name field with symbols shows message that name is invalid | "Українська" is not a valid locale | | ./spec/features/account/create_calculator_spec.rb:59 | Create Calculator Page when user left the Name field blank shows message that name can't be blank | "Українська" is not a valid locale | | ./spec/features/account/histories_spec.rb:14 | visit admin page signed in admin visit page (page) contains some content | "Українська" is not a valid locale | | ./spec/features/account/products_spec.rb:11 | visit admin page visits admin page | "Українська" is not a valid locale | | ./spec/features/account/update_calculator_spec.rb:16 | Update Calculator Page when user clicks button Update calculator shows message that calculator has been successfully updated | "Українська" is not a valid locale | | ./spec/features/account/update_calculator_spec.rb:25 | Update Calculator Page when user fill in the Name field with name shorter than 2 symbols shows message that name is too short | "Українська" is not a valid locale | | ./spec/features/account/update_calculator_spec.rb:33 | Update Calculator Page when user fill in the Name field with symbols shows message that name is invalid | "Українська" is not a valid locale | | ./spec/features/account/users_spec.rb:15 | visit admin page visits admin page | "Українська" is not a valid locale | | ./spec/features/account/users_spec.rb:22 | visit admin page when user clicks show icon redirects to user info page | "Українська" is not a valid locale | | ./spec/features/account/users_spec.rb:40 | visit admin page when user clicks edit icon redirects to user edit info page | "Українська" is not a valid locale | | ./spec/features/account/users_spec.rb:58 | visit admin page when user clicks lock-open icon shows the correct confirmation message for blocking | "Українська" is not a valid locale | | ./spec/features/account/users_spec.rb:74 | visit admin page when user clicks lock icon shows the correct confirmation message for unblocking | "Українська" is not a valid locale | | ./spec/features/account/users_spec.rb:91 | visit admin page when trying to block an admin user shows an alert message and redirects to account users path | "Українська" is not a valid locale | | ./spec/features/account/users_spec.rb:101 | visit admin page when edit user`s info correctly redirects to user info page | "Українська" is not a valid locale | | ./spec/features/account/users_spec.rb:118 | visit admin page when edit user`s info wrongly show error messages | "Українська" is not a valid locale | | ./spec/requests/account/calculators_spec.rb:25 | Account::CalculatorsController GET #index when in production environment renders the 'under_construction' template | "Українська" is not a valid locale | | ./spec/requests/account/calculators_spec.rb:35 | Account::CalculatorsController GET #index when in local environment loads calculators and renders the index template | "Українська" is not a valid locale | | ./spec/requests/account/messages_spec.rb:9 | Account::ProductsController GET :index is successful | "Українська" is not a valid locale | | ./spec/requests/account/messages_spec.rb:17 | Account::ProductsController GET :index returns the expected attributes | "Українська" is not a valid locale | | ./spec/requests/account/messages_spec.rb:29 | Account::ProductsController GET :show is successful | "Українська" is not a valid locale | | ./spec/requests/account/users_spec.rb:16 | Account::UsersController GET #index returns a successful html response | "Українська" is not a valid locale | | ./spec/requests/account/users_spec.rb:34 | Account::UsersController GET #index returns the expected attributes | "Українська" is not a valid locale | | ./spec/requests/account/users_spec.rb:46 | Account::UsersController GET #new returns a successful response | "Українська" is not a valid locale | | ./spec/requests/account/users_spec.rb:82 | Account::UsersController POST #create with invalid parameters does not create a new user | "Українська" is not a valid locale | | ./spec/requests/account/users_spec.rb:108 | Account::UsersController PATCH #update with invalid parameters does not update the user | "Українська" is not a valid locale | | ./spec/requests/account/users_spec.rb:123 | Account::UsersController PATCH /account/users/:id when trying to block an admin user sets an alert message and redirects to the admin user account page | "Українська" is not a valid locale | | ./spec/requests/account/users_spec.rb:136 | Account::UsersController PATCH /account/users/:id when trying to block a non-admin user blocks the user successfully | "Українська" is not a valid locale | | ./spec/requests/calculators_spec.rb:152 | CalculatorsController POST #create with invalid attributes does not create a calculator | "Українська" is not a valid locale | | ./spec/requests/categories_spec.rb:12 | Account::CategoriesController GET :index is successful | "Українська" is not a valid locale | | ./spec/requests/categories_spec.rb:18 | Account::CategoriesController GET :index returns the expected attributes | "Українська" is not a valid locale | | ./spec/requests/categories_spec.rb:30 | Account::CategoriesController GET :new is successful | "Українська" is not a valid locale | | ./spec/requests/categories_spec.rb:38 | Account::CategoriesController GET :edit is successful | "Українська" is not a valid locale | | ./spec/requests/categories_spec.rb:58 | Account::CategoriesController POST :create with invalid parameters is not successful | "Українська" is not a valid locale | | ./spec/requests/categories_spec.rb:81 | Account::CategoriesController PATCH :update with invalid parameters is not successful | "Українська" is not a valid locale | | ./spec/requests/dashboard_request_spec.rb:8 | Account::DashboardController when the user is signed in GET :index returns a success response | "Українська" is not a valid locale | | ./spec/requests/products_spec.rb:9 | Account::ProductsController GET :index is successful | "Українська" is not a valid locale | | ./spec/requests/products_spec.rb:17 | Account::ProductsController GET :index returns the expected attributes | "Українська" is not a valid locale | | ./spec/requests/products_spec.rb:29 | Account::ProductsController GET :new is successful | "Українська" is not a valid locale | | ./spec/requests/products_spec.rb:38 | Account::ProductsController GET :show is successful | "Українська" is not a valid locale | | ./spec/requests/products_spec.rb:50 | Account::ProductsController GET :edit is successful | "Українська" is not a valid locale | | ./spec/requests/products_spec.rb:76 | Account::ProductsController POST :create with duplicated attributes doesn't create a duplicated product | "Українська" is not a valid locale | | ./spec/requests/products_spec.rb:88 | Account::ProductsController POST :create with invalid attributes does not create a product | "Українська" is not a valid locale | | ./spec/requests/products_spec.rb:118 | Account::ProductsController PATCH :update with invalid attributes does not update product | "Українська" is not a valid locale | | ./spec/requests/site_setting_spec.rb:15 | Account::SiteSettingsController GET #edit when user is authenticated renders the edit template | "Українська" is not a valid locale | | ./spec/requests/site_setting_spec.rb:46 | Account::SiteSettingsController PATCH #update with invalid params renders edit page with error message | "Українська" is not a valid locale | | ./spec/requests/site_setting_spec.rb:76 | Account::SiteSettingsController PUT #revert with invalid params renders edit page with error message | "Українська" is not a valid locale |