itamart / moodle-mod_dataform

The Dataform is an enhanced counterpart of the standard Database activity module
17 stars 19 forks source link

Group Peer Review - Email notification of graded review is not sent to the author #14

Open hartmut1s opened 6 years ago

hartmut1s commented 6 years ago

I am using Moodle 3.3.1 (Build: 20170710) with Dataform 3.0.4 (2015111604). In a group peer review activity, I get notified when students upload their first draft, review, or final draft. When I grade their review, they do not receive an email. Can you please help me and find out what I need to change so that students will receive an email notification after I have graded their review?

As I couldn't attach the Dataform preset file, I uploaded the file to my Dropbox. HERE is the link.

itamart commented 6 years ago

I'll take a look and let you know.

itamart commented 6 years ago

Hartmut, which notification rule should be in effect for this? Is it 'Graded review of research paper'? If so, it is configured to event 'Entry created'. But if you just update fields in the student's entry, you don't create an entry but rather update it, and so the event should be Entry updated. Does that help?

hartmut1s commented 6 years ago

Itamar, thank you for looking into this issue. Yes, it is the notification that students should receive after I have graded their review. I changed the notification to "Entry updated" but the test student hasn't received any email. I have no difficulties getting email notifications when students have submitted their work but they don't get notified after I am done. With Moodle 3.2 something changed regarding communication. In the release notes for Moodle 3.2, I found this: MDL-44467 - Return-Path should use no-reply address instead of support email; use only no-reply email or allowed domains in "From" header. (See HERE) I guess that this affects the event notification in a Dataform activity when teachers want to inform students that the grading is done. Other than this I like using the Dataform module for group peer activities.

itamart commented 6 years ago

I'll investigate further. I'm preparing a 3.3 version and indeed I had to make a few adjustments in the dataform notification component due to changes in core moodle. It will be released soon. In the mean time, have you tried other configuration settings? For example, you can make it a conversation rather than a notification. With conversation, make sure that the sender is a real user (e.g. admin) rather than no-reply.

hartmut1s commented 6 years ago

Itamar, I have tested other configuration settings of "Graded review of research paper." I tried the notification of students by setting conversation to author and another time to event. The test student hasn't received an email. Perhaps the next release will solve this issue. I am glad you are working on releasing a Dataform version for Moodle 3.3.

hartmut1s commented 6 years ago

The "event" in Dataform notification no longer triggers an email. When I change the notification to "no reply," students receive an email.

itamart commented 6 years ago

Please try with 3.3.2 and let me know if the issue persists.

hartmut1s commented 6 years ago

Many thanks for updating the Dataform module and for supporting PHP 7.

I installed Dataform (version 3.3.2), purged all caches and tested the updated module with a previous Dataform activity in Moodle 3.3.1. I couldn't see the overview view. Debug message is:

Fatal error: Class 'dataformfield_dataformview_dataformview' not found in C:\Bitnami\wampstack-5.6.30-2\apps\moodle\htdocs\mod\dataform\classes\field_manager.php on line 308

itamart commented 6 years ago

The dataformview field has never been part of the standard distribution of the dataform. I will try this weekend to allocate time for testing it with the new version and pushing an update if needed.

hartmut1s commented 6 years ago

I highly appreciate your effort to test the dataformview field. With it, the group peer review will work again.