search

iterative / dvc-objects

dvc objects - contains filesystem and object-db level abstractions to use in dvc and dvc-data
https://dvc.org
Apache License 2.0
12 stars 21 forks source link

cleanup callback #276

Closed skshetry closed 9 months ago

skshetry commented 9 months ago

Structured callbacks are now available in fsspec>=2024.2.0, so we can remove most of the code here. Almost all of the dvc_objects.fs.callbacks is deprecated, and will be removed within 4.x minor release, including TqdmCallback.

TqdmCallback can be replaced with fsspec's TqdmCallback, or can be overridden very easily. This will likely be moved to dvc-data for now.

Similarly, dvc_objects._tqdm module is deprecated and is slated for removal within 4.x minor release. The code will likely move over to dvc-data.

codecov-commenter commented 9 months ago

Codecov Report

Attention: 17 lines in your changes are missing coverage. Please review.

Comparison is base (edc151c) 63.83% compared to head (67ef3eb) 68.84%.

:exclamation: Current head 67ef3eb differs from pull request most recent head c8359c1. Consider uploading reports for the commit c8359c1 to get more accurate results

Files Patch % Lines
src/dvc_objects/fs/base.py 14.28% 12 Missing :warning:
src/dvc_objects/fs/callbacks.py 58.33% 5 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #276 +/- ## ========================================== + Coverage 63.83% 68.84% +5.01% ========================================== Files 26 27 +1 Lines 2107 2035 -72 Branches 333 338 +5 ========================================== + Hits 1345 1401 +56 + Misses 713 584 -129 - Partials 49 50 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.