Closed mkdjr closed 1 week ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 91.01%. Comparing base (
2431ec6
) to head (6353ed5
). Report is 4 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
thanks @mkdjr ! Is it still in draft, needs more testing?
Oh yeah, I forgot to take it out of its drafted state. I think it's good to go, but should probably be followed up with a future PR to automate updating the rev
field as dvc
gets new releases.
[x] ❗ I have followed the Contributing to DVC checklist.
[x] 📖 If this PR requires documentation updates, I have created a separate PR (or issue, at least) in dvc.org and linked it here.
1. Pin
rev
argument inpre-commit-config.yaml
writerThe
pre-commit
package recommends against using mutable references such asmain
, as the version of the package pulled in the hook (in this casedvc
), does not get updated after the first timepre-commit
installs it. This PR addresses this by instead pinning the hooks todvc
v3.56.0. This change is made with the goal of:pre-commit
warning, anddvc
version thatpre-commit
refers to whendvc
receives a new release.As a reference,
ruff
, the python linter and formatter, keeps its pre-commit hooks in a separate repository. This repository has its own pre-commit hooks that automatically pull the latest version ofruff
and updates the version pointer in thepre-commit-hooks.yaml
file. Maybedvc
could do something like this in the future to automate thepre-commit-hooks.yaml
update process.2. Update
stages
keywordsAdditionally,
pre-commit
has now deprecated the acceptable values for thestages
keyword forhooks
. I have updated thedvc install
command and thepre-commit-hooks.yaml
file to reflect this change.As this change was made in
pre-commit
v3.2.0, thedvc
hooks now requirepre-commit
to be updated to at least v3.2.0.Closes #9897.
Associated documentation PR: https://github.com/iterative/dvc.org/pull/5323.