search

itinycheng / flink-connector-clickhouse

Flink SQL connector for ClickHouse. Support ClickHouseCatalog and read/write primary data, maps, arrays to clickhouse.
Apache License 2.0
346 stars 148 forks source link

Don't add trailing slash to the base URL #108

Closed sap1ens closed 3 weeks ago

sap1ens commented 8 months ago

Currently, it's not possible to provide URLs with additional parameters like ?ssl=true because of the trailing slash.

The slash is not needed: baseUrl is primarily used by ClickHouseUtil.getJdbcUrl, which adds it anyway.

czy006 commented 8 months ago

Thanks for your contribution, we are currently building work on JDBC version 0.5.0, how about merging this into the 1.16 branch? cc @sap1ens

sap1ens commented 8 months ago

Done! https://github.com/itinycheng/flink-connector-clickhouse/pull/110

sap1ens commented 3 weeks ago

@itinycheng hi! Should I create a new PR or an issue? The problem is still here, I can't use ?ssl=true in the URL with this connector.

itinycheng commented 3 weeks ago

@itinycheng hi! Should I create a new PR or an issue? The problem is still here, I can't use ?ssl=true in the URL with this connector.

Hi @sap1ens It seems that the master branch isn't stable for now, we can pay attention to this issue later.

cc @czy006

sap1ens commented 3 weeks ago

Ok, created https://github.com/itinycheng/flink-connector-clickhouse/issues/129