search

its-rigs / Trolly

A Python wrapper around the Trello API. Provides a group of Python classes to represent Trello Objects. All classes come with basic Trello API method calls and are easily extensible to suit your needs. See the README for more details.
MIT License
100 stars 29 forks source link

tests require network connection #46

Closed mcepl closed 4 years ago

mcepl commented 4 years ago

When trying to run the test suite while building openSUSE packages for Trolly, we don’t have any network connection available outside of the build system. Therefore all tests fail. Is it possible to mock those network connections somehow?

Complete build log with all details

its-rigs commented 4 years ago

Hi, I haven't supported this codebase for some time. I had a look at the tests and honestly they're basically all worthless. They're integration tests as opposed to unit tests, so they require a network connection.

I did want to do a big rewrite but it seems like py-trello has more ongoing support, so it didn't seem worth it.

If you can think of a quick way to solve the issue or would like to put in a PR I'm happy to merge and publish changes.

mcepl commented 4 years ago

Thank you, I will just give up on the test suite as the bad job until I hear something else from you.