nus-se-bot
commented
4 years ago Team's Response
"delete -1" classified as an "incorrect command format" because it recognises the "-" symbol as a dash, which our command line does not support, rather than classifying it as an integer value, which would produce the "invalid index" error.
However, I would like to highlight that in our UG, we did mention that the correct format is "the index must be a positive integer", and "-1" is not positive. Therefore, the input format of "delete -1" is actually incorrect as it did not follow our UG's instructions, and our error message is actually accurate for this situation.
In addition, I do not believe this is a high severity problem as it is not a problem that can cause our product to be unusable. It seems that the tester has misunderstood the severity labels, as a supposedly mistaken error message would not cause major problems to the user and the application to be unusable.
Items for the Tester to Verify
:question: Issue response
Team chose [response.Rejected]
- [x] I disagree
Reason for disagreement: The problem of "-" recognised as a string can be easily corrected by adding a few simple lines of code. In addition, the user may not be a computer science student and does not know that the "-" is treated as a string given to them. For them this may seem as a proper input as "-1" is an integer.
In addition, they also mentioned that "delete -1" is in the wrong format. By format I only understand it as the placements of the different keywords. hence the format aksed by the team is "delete INDEX". Yes, they have mentioned that INDEX should be a positive integer. However this is details about the parameters and not format.
Hence, it does not give clear instructions to the user on their wrong input.
:question: Issue severity
Team chose [severity.VeryLow]
Originally [severity.High]
- [x] I disagree
Reason for disagreement: Again VeryLow is only used for cosmetic errors or typo errrors. This is not a typo. This is failing to properly realise the different possible errors that users might encounter. A user may have accidentally placed "-" in front of their input and hence they would not realise that their error based on the error message as they think that their inputs are in the correct format. Hence, users may have to look over UG again to figure out the error, therfore greatly inconveniencing them and making app unusable.
Command Line Used: delete -1
Though I have input the digits in correct format of
delete INDEX, it still gives me error below:Invalid command format! delete: Deletes the flashcard identified by the index number used in the displayed flashcard list.