itssodium / pe

0 stars 0 forks source link

Error message displayed for suitable index #4

Open itssodium opened 4 years ago

itssodium commented 4 years ago

Command line Instruction: list s/1.0000

The UG did not mention that Index is supposed to be postive integer, however error message displayed. Screenshot 2020-11-13 at 4.55.50 PM.png

nus-se-bot commented 4 years ago

Team's Response

The tester has misread our UG. We clearly stated that it should be "list s/SET_NUMBER" rather than "list INDEX". They might have been confused with the documentation for view or edit, where both of these commands take in an "INDEX". Set numbers have been mentioned in the DG to be "positive integers between 1 to 20", and hence the tester has in fact, used an invalid input. Our error message would be correct in this case.

In addition, I believe that the tester has misunderstood what an error of High severity means. Even if our error message for this input was inaccurate, it would not have caused the program to crash or be unusable.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: They have claimed in their UG that the INDEX should be a positive integer. However, as seen in the image below, they have not mentioned it, therefore, I would assume that any other numbers such as 1.00 or 10.000 would be acceptable values. Hence, inputs such as list 1.00 should be correct inputs. Hence, it is wrong for system to throw an error. In addition, the error thrown does not make sense as indeed a set number is being input.

Screenshot 2020-11-20 at 11.50.30 AM.png


:question: Issue severity

Team chose [severity.VeryLow] Originally [severity.High]

Reason for disagreement: A VeryLow bug is one that is purely cosmetic or a typo. This is not a typo but rather a serious functionality bug as the UG did not mention that the Index does not say that the inputs have to be an integer and the error message is also not useful in pointing out the flaw of inserting a decimal value adn just says to add a number as a parameter which has already been done by the user. Thus it inconviniences the reader and does not talk address the problem with the input properly. Hence it is of High Severity.